From 9e0a71866a4e6b3ae83c2fa7cfc167a15554e1cf Mon Sep 17 00:00:00 2001
From: Astrian Zheng <happy.wheel6743@astrian.moe>
Date: Sun, 12 Jan 2025 10:02:08 +1100
Subject: [PATCH] refactor: simplify invoice creation by extracting payer
 information into a separate object

---
 backend/src/func/issueInvoice.ts | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/backend/src/func/issueInvoice.ts b/backend/src/func/issueInvoice.ts
index 70eb75a..749256d 100644
--- a/backend/src/func/issueInvoice.ts
+++ b/backend/src/func/issueInvoice.ts
@@ -24,20 +24,14 @@ export default async (prisma: PrismaClient, payerId: number, period: Date[], ite
 	if (!payer) throw new HttpError(ErrorDescEnum.related_item_not_found, 400, ['payer_id'])
 
 	// 创建新收据
-	const newInvoice = new Invoice(
-		0,
-		new Date(),
-		period,
-		items,
-		dueDate,
-		{
-			id: payer.payer_id,
-			name: payer.payer_name,
-			address: payer.payer_address,
-			abn: payer.payer_abn ? payer.payer_abn : undefined,
-			email: payer.payer_email
-		}
-	)
+	const payerInfo = {
+		id: payer.payer_id,
+		name: payer.payer_name,
+		address: payer.payer_address,
+		abn: payer.payer_abn ? payer.payer_abn : undefined,
+		email: payer.payer_email
+	}
+	const newInvoice = new Invoice(0, new Date(), period, items, dueDate, payerInfo)
 	if (note) await newInvoice.setNote(note)
 	await newInvoice.save(prisma)
 }
\ No newline at end of file